-
Notifications
You must be signed in to change notification settings - Fork 433
Fix CalendarPicker timezone handling #4284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CalendarPicker timezone handling #4284
Conversation
Exposed `setTimeZone` and `getTimeZone` methods in `CalendarPicker` to allow explicit timezone handling. This resolves off-by-one errors when displaying dates (e.g., UTC) in a different local timezone. Added `CalendarPickerTest.java` to verify the fix and prevent regression.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
|
Compared 30 screenshots: 30 matched. Native Android coverage
|



This change exposes
setTimeZoneandgetTimeZonemethods in the package-privateCalendarPickerclass. This allows the internalCalendarinstance to use a specific timezone instead of defaulting to the system timezone. This is necessary to correctly display dates (as instances in time) that fall on different days depending on the timezone (e.g., a UTC midnight date appearing as the previous day in PST).A new unit test
CalendarPickerTesthas been added tomaven/core-unitteststo reproduce the reported failure and verify the fix.PR created automatically by Jules for task 8989843240476949235 started by @shai-almog